Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add special case for Serial Port binary (.node) modules #415

Merged
merged 2 commits into from
May 8, 2024
Merged

fix: Add special case for Serial Port binary (.node) modules #415

merged 2 commits into from
May 8, 2024

Conversation

RogerHardiman
Copy link
Contributor

Tested with prebuilds and compiling serialport from source

@RogerHardiman
Add special case for Serial Port binary (.node) modules
ab230b4 
Tested with prebuilds and compiling serialport from source
@RogerHardiman RogerHardiman requested review from ijjk and styfle as code owners May 3, 2024 11:31
@RogerHardiman RogerHardiman mentioned this pull request May 3, 2024
Closed
@RogerHardiman RogerHardiman changed the title Add special case for Serial Port binary (.node) modules fix: Add special case for Serial Port binary (.node) modules May 3, 2024
@styfle
Copy link
Member

styfle commented May 4, 2024

Please add an integration test in ./test/integration to confirm this works as expected, thanks!

@RogerHardiman
Copy link
Contributor Author

Good idea to add an integration test. I noticed another one of the binary .node special cases had an integration test.

@RogerHardiman
Copy link
Contributor Author

Just a note to myself that currently one integration test fails with the error below before I add my new integration test

  ● should correctly trace and correctly execute sharp-pnpm.js

    Command failed: corepack enable && pnpm i



Test Suites: 1 failed, 3 passed, 4 total
Tests:       1 failed, 1368 passed, 1369 total
Snapshots:   0 total
Time:        530.549 s
Ran all test suites.

@RogerHardiman
Copy link
Contributor Author

This has been updated with an integrating test.
The test code (serialport.js) throws an exception if the .node modules are missing,

styfle
styfle approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit e001d05 into vercel:main May 8, 2024
10 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

🎉 This PR is included in version 0.26.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@styfle styfle mentioned this pull request May 16, 2024
Merged
styfle added a commit to vercel/next.js that referenced this pull request May 16, 2024
@styfle
fix: bump nft@0.27.1 (#65854)
780e77b 
- vercel/nft#415
([e001d05](vercel/nft@e001d05))
- vercel/nft#417
([ddc5cba](vercel/nft@ddc5cba))
- vercel/nft#419
([db6c65a](vercel/nft@db6c65a))
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
@styfle @panteliselef
fix: bump nft@0.27.1 (vercel#65854)
eb1246e 
- vercel/nft#415
([e001d05](vercel/nft@e001d05))
- vercel/nft#417
([ddc5cba](vercel/nft@ddc5cba))
- vercel/nft#419
([db6c65a](vercel/nft@db6c65a))
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
@styfle @ForsakenHarmony
fix: bump nft@0.27.1 (#65854)
62ee4f4 
- vercel/nft#415
([e001d05](vercel/nft@e001d05))
- vercel/nft#417
([ddc5cba](vercel/nft@ddc5cba))
- vercel/nft#419
([db6c65a](vercel/nft@db6c65a))
@leonardoadame leonardoadame mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RogerHardiman @styfle